dataplane: close HTTP response body in relayWrite - #344
Open
Arjun Mehta (Arjunmehta312) wants to merge 1 commit into
Open
dataplane: close HTTP response body in relayWrite#344Arjun Mehta (Arjunmehta312) wants to merge 1 commit into
Arjun Mehta (Arjunmehta312) wants to merge 1 commit into
Conversation
Author
|
John Stairs (@johnstairs) Hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a resource leak in
relayWrite()where HTTP response bodies were drained but never closed.Bug:
relayWrite()callsio.Copy(io.Discard, resp.Body)after the relay request, but did not close the response body afterward. This can prevent proper HTTP connection reuse and leak response-body resources.Fix: Close
resp.Bodyafter draining it, following the existing response-body handling patterns inreadRelay(),pingRelay(), andContainerClient.Do().Test: Added
TestRelayWriteClosesResponseBody, which uses a tracking response body to verify that the PUT response body is closed.Validation:
go test ./...gofmtgit diff --checkScope: Small, targeted lifecycle fix with no changes to retry, error-handling, or metrics behavior.