Update hash map entries in place - #56
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the ListTable implementation to update HashMap entries in place (now that Verus supports returning mutable references), avoiding the previous remove–modify–reinsert pattern for ListTableEntry updates.
Changes:
- Refactors
ListTableEntry::committo mutateselfin place (&mut self) and updates commit propagation to useHashMap::entry. - Refactors
ListTableEntry::appendto mutateselfin place (&mut self) and updates append flows to avoid temporarily removing the entry from the map. - Adjusts append-case helper APIs to pass only the needed
ListSummarysnapshot (old_summary) and then update the map entry in place.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| capybaraKV/capybarakv/src/kv2/lists/commit_v.rs | Switches commit to in-place mutation and updates map updates to use HashMap::entry for occupied entries. |
| capybaraKV/capybarakv/src/kv2/lists/append_v.rs | Switches append to in-place mutation and refactors append cases to avoid remove/insert, updating entries via entry / get_mut. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hayley LeBlanc (hayley-leblanc)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time CapybaraKV was released, Verus didn't support general mutable references. So there were some places in the code where it removed a key/value mapping
(k, v1), updatedv1tov2, then inserted(k, v2).Now that Verus does support returning mutable references, we can update that value in place, for greater simplicity and presumably better performance.
It presumably goes without saying that most of this code was written by AI. In this case, it was GPT-5.6 Sol.