sshwire improvements - #64
Merged
Merged
Conversation
Add sshwire-derive tests
Add some extra derive checks for sshwire(unknown) variants.
Added docs describing function purpose.
This is emitted by sshwire-derive, so doesn't really belong in packets module.
UnknownVariant sounds similar to sunset::Error::UnknownMethod which has a different meaning, and sshwire-derive might soon emit that.
Bring back WireError::UnknownVariant to return in the case an unknown variant is encountered.
This is fairly rare, and instead can use .push(). This avoids accidentally encoding expecting something like BinString. There wasn't an equivalent SSHDecode since length is unknown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sshwire-derive can now encode enum tuple and struct variants. These aren't currently used in SSH protocol, but can be used in future for inter-application encoding.
Handling of unknown variants has changed, with a new
sshwire(decode_unknown_fail)attribute to return an error, so enums don't need anUnknownvariant.Error::UnknownVariantnow has a different meaning,EncodeUnknownis the name for the old error.&[u8]no longer has SSHEncode since it could be unclear what it would do.