-
Notifications
You must be signed in to change notification settings - Fork 169
[Server] Add outgoing (elicitation, sampling) request and client response events #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
omouren
wants to merge
9
commits into
modelcontextprotocol:main
Choose a base branch
from
FrenchFounders:feature/elicit-lifecycle-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f221c38
Add outgoing request and client response events
omouren 6c0f6fb
Update src/Server/Protocol.php
omouren 25f3deb
Rename OutgoingRequestEvent to ServerRequestEvent and streamline mess…
omouren 1c07c98
Merge branch 'main' into feature/elicit-lifecycle-events
omouren a626b04
Fix phpcs
omouren 40286f3
Merge branch 'main' into feature/elicit-lifecycle-events
omouren 96cfe12
Merge branch 'main' into feature/elicit-lifecycle-events
omouren 7aa5c7c
Dispatch protocol lifecycle events on modern connections
omouren f53d660
Add server-initiated request events and refine fiber termination hand…
omouren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the official PHP MCP SDK. | ||
| * | ||
| * A collaboration between Symfony and the PHP Foundation. | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Mcp\Event; | ||
|
|
||
| use Mcp\Schema\JsonRpc\Error; | ||
| use Mcp\Schema\JsonRpc\Response; | ||
| use Mcp\Server\Session\SessionInterface; | ||
|
|
||
| /** | ||
| * Event dispatched when the server receives a client response to a prior outgoing request. | ||
| * | ||
| * @author Olivier Mouren <mouren.olivier@gmail.com> | ||
| */ | ||
| final class ClientResponseEvent | ||
| { | ||
| /** | ||
| * @param Response<mixed>|Error $response | ||
| */ | ||
| public function __construct( | ||
| private readonly Response|Error $response, | ||
| private readonly SessionInterface $session, | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @return Response<mixed>|Error | ||
| */ | ||
| public function getResponse(): Response|Error | ||
| { | ||
| return $this->response; | ||
| } | ||
|
|
||
| public function getSession(): SessionInterface | ||
| { | ||
| return $this->session; | ||
| } | ||
|
|
||
| public function getId(): string|int|null | ||
| { | ||
| return $this->response->getId(); | ||
| } | ||
|
|
||
| public function isError(): bool | ||
| { | ||
| return $this->response instanceof Error; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the official PHP MCP SDK. | ||
| * | ||
| * A collaboration between Symfony and the PHP Foundation. | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Mcp\Event; | ||
|
|
||
| use Mcp\Schema\JsonRpc\Request; | ||
| use Mcp\Server\Session\SessionInterface; | ||
|
|
||
| /** | ||
| * Event dispatched when the server sends a request to the client (e.g. elicitation/create, sampling/createMessage). | ||
| * | ||
| * @author Olivier Mouren <mouren.olivier@gmail.com> | ||
| */ | ||
| final class ServerRequestEvent | ||
| { | ||
| public function __construct( | ||
| private readonly Request $request, | ||
| private readonly int $timeout, | ||
| private readonly SessionInterface $session, | ||
| ) { | ||
| } | ||
|
|
||
| public function getRequest(): Request | ||
| { | ||
| return $this->request; | ||
| } | ||
|
|
||
| public function getSession(): SessionInterface | ||
| { | ||
| return $this->session; | ||
| } | ||
|
|
||
| public function getTimeout(): int | ||
| { | ||
| return $this->timeout; | ||
| } | ||
|
|
||
| public function getMethod(): string | ||
| { | ||
| return $this->request::getMethod(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be moved into the
if (null !== $parentRequest), no?or maybe just invert that to keep the if small
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chr-hertel
save() has to stay even when $parentRequest is null. pull() already forgets SESSION_FIBER_PARENT_REQUEST. Without a save that deletion never hits the session store, so the next createWithId() would see the parent request again.