[Client] Expose session ID from HttpTransport - #497
Merged
chr-hertel merged 2 commits intoSep 4, 2026
Conversation
RobLoach
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
September 3, 2026 17:43
chr-hertel
previously approved these changes
Sep 4, 2026
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Fair with that disclaimer in the comment - won't be there for long with modern era discontinuing the session, but makes sense for now.
Thanks @RobLoach!
That revision removed protocol-level sessions (SEP-2567), so the getter is always null there. Adds the changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
HttpTransport::getSessionId()so request-scoped callers can persist the server-minted session ID and re-inject it later via the constructor's$headersparameter. Fixes #496.