fix(session): allow max safe event revisions - #773
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
Someone is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
nightcityblade
force-pushed
the
fix/issue-762
branch
from
August 16, 2026 15:17
76b0f56 to
ce7bbb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Review event IDs rejected valid 16-digit state revisions, including
Number.MAX_SAFE_INTEGER, even though publication addresses accept all non-negative safe integers.Why This Change Was Made
The event ID grammar now accepts up to 16 digits and continues to use
Number.isSafeIntegeras the authoritative numeric bound.User Impact
SSE review event IDs now round-trip across the full supported revision range while unsafe and oversized revisions remain rejected.
Evidence
bun test src/session/reviewEventProtocol.test.ts(21 passed)bunx oxfmt --check src/session/reviewEventProtocol.ts src/session/reviewEventProtocol.test.tsbunx oxlint src/session/reviewEventProtocol.ts src/session/reviewEventProtocol.test.ts --deny-warningsbun run typecheckFixes #762