fix(commands): construct complete synthetic key events - #774
Open
nightcityblade wants to merge 1 commit into
Open
fix(commands): construct complete synthetic key events#774nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
Someone is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and impact
Synthetic command events were partial objects asserted as
KeyEvent. Matchers or programmatic handlers that inspected required event metadata or propagation state could observe missing or inert behavior.Approach
Construct OpenTUI's exported
KeyEventwith the existing chord fields plus explicitpress/rawsynthetic defaults. This keeps chord matching unchanged while using OpenTUI's real prevention and propagation state. No command-dispatch or public extension API behavior is otherwise changed.This belongs in the existing core command-key helper because it owns synthetic events used by conflict detection and command invocation.
Verification
bun test src/lib/commandKeys.test.ts(3 passed)bunx oxfmt --check src/lib/commandKeys.ts src/lib/commandKeys.test.ts .changeset/complete-synthetic-key-events.mdbunx oxlint src/lib/commandKeys.ts src/lib/commandKeys.test.ts --deny-warningsbun run typecheckTested on macOS. No visual evidence is applicable because this changes the internal event contract without altering rendering.
Fixes #767