Skip to content

fix(extensions): isolate legacy sidebar files - #775

Open
Tethys0 wants to merge 1 commit into
modem-dev:mainfrom
Tethys0:fix/legacy-sidebar-files
Open

fix(extensions): isolate legacy sidebar files#775
Tethys0 wants to merge 1 commit into
modem-dev:mainfrom
Tethys0:fix/legacy-sidebar-files

Conversation

@Tethys0

@Tethys0 Tethys0 commented Aug 16, 2026

Copy link
Copy Markdown

Summary

  • adapt deprecated sidebar views to receive a mutable copy of host-owned files
  • preserve the readonly projection for modern panes
  • add a render-level regression test for legacy files.sort()

Closes #764

Verification

  • npx --yes bun test src/ui/AppHost.extension-sidebar.test.tsx --test-name-pattern "legacy sidebar can sort" (RED before fix: frozen-array TypeError; GREEN after)
  • npx --yes bun test src/ui/AppHost.extension-sidebar.test.tsx
  • npx --yes bun run format:check
  • git diff --check

Scope

This preserves the deprecated mutable ExtensionSidebarViewProps.files contract without changing modern ExtensionPaneProps.files.

@greptile-apps

greptile-apps Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

@Tethys0 is attempting to deploy a commit to the Modem Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt deprecated sidebar props without exposing frozen files as mutable

1 participant