fix(ui): isolate OpenTUI scroll reset compatibility - #786
Open
atirna wants to merge 5 commits into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@atirna is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shift+Wheel has to clear OpenTUI wheel remainders after Hunk reroutes the input horizontally. The previous inline private-member assertion used optional chaining, so an OpenTUI rename could silently let later input move the review viewport.
Approach
Validation
bun run typecheckbun run lintbun run format:checkbun run check:docsbun run test(2807 passed, 24 skipped)bun test src/ui/components/panes/DiffPane.test.tsx src/ui/AppHost.interactions.test.tsx --test-name-pattern "resetOpenTuiScrollAccumulators|shift plus (mouse wheel|native horizontal)"(5 passed)bun test test/pty/layout.test.ts --test-name-pattern "shifted mouse-wheel input"(1 passed)Fixes #771