fix(stml): preserve content when rows cannot fit - #787
Open
benvinegar wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR fixes STML row fallback behavior when declared fixed widths and minimum flex widths cannot fit.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The revised fit check prevents overcommitted horizontal allocation, while the fallback constrains stacked children to the row width and now retains loose inline content. Important Files Changed
Reviews (1): Last reviewed commit: "fix(stml): preserve content when rows ca..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test src/ui/lib/stml src/ui/lib/agentNoteGeometry.test.ts src/ui/fileViews/geometry.test.ts src/ui/components/ui-components.test.tsx src/ui/hooks/useTerminalReview.test.tsx— 187 passedbun run typecheckbun run lintbun run check:packbun run test:integration— 117 passedbun run test:tty-smoke— 9 passedA full
bun testcompleted 3,042 tests successfully; its only failures were the two existing website Playwright specs being discovered by Bun's test runner.This PR description was generated by Pi using gpt-5.6-sol