docs(extensions): move current-line lens to its own repo - #801
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR moves the current-line lens example to the external Hunk Lens repository while preserving host integration coverage through a test-owned fixture.
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking indentation inconsistency in the new test fixture. The removed example's in-repository test consumer is replaced by a loadable fixture preserving the asserted pane behavior, and the documented install shorthand matches the CLI parser; only the fixture's formatting convention needs attention. Files Needing Attention: test/pty/fixtures/current-line-lens/index.tsx Important Files Changed
Prompt To Fix All With AI### Issue 1
test/pty/fixtures/current-line-lens/index.tsx:7-18
**Use four-space fixture indentation**
The new fixture uses two-space indentation throughout the component and registration blocks instead of the repository's required four-space TypeScript indentation, creating inconsistent formatting and maintenance churn.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "docs(extensions): move current-line lens..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| function TestCurrentLineLens({ currentLine, theme, width }: ExtensionPaneProps): ReactNode { | ||
| if (!currentLine) return null; | ||
| const label = LABEL.slice(0, Math.max(0, width)); | ||
| const rule = label + "─".repeat(Math.max(0, width - label.length)); | ||
|
|
||
| return ( | ||
| <box style={{ width, height: 3, flexDirection: "column", backgroundColor: theme.panel }}> | ||
| <text fg={theme.border}>{rule}</text> | ||
| {currentLine.render("old", width) as ReactNode} | ||
| {currentLine.render("new", width) as ReactNode} | ||
| </box> | ||
| ); |
There was a problem hiding this comment.
The new fixture uses two-space indentation throughout the component and registration blocks instead of the repository's required four-space TypeScript indentation, creating inconsistent formatting and maintenance churn.
Context Used: guidelines.mdc Cursor rule (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/pty/fixtures/current-line-lens/index.tsx
Line: 7-18
Comment:
**Use four-space fixture indentation**
The new fixture uses two-space indentation throughout the component and registration blocks instead of the repository's required four-space TypeScript indentation, creating inconsistent formatting and maintenance churn.
**Context Used:** guidelines.mdc Cursor rule ([source](https://github.com/modem-dev/modem/blob/main/.cursor/rules/guidelines.mdc))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Summary
modem-dev/hunk-lenshunk extension installcommand from maintainer and user docsValidation
bun run format:checkbun run lintbun run typecheckbun test ./src ./packages ./scripts ./test/cli ./test/session(2,973 passed, 10 skipped)bun test test/pty/cursor-line.test.ts(9 passed)bun run check:docshunk-lens: format, lint, typecheck, and 3 unit testsMerge note
modem-dev/hunk-lenswas created private-first. Make it public before merging so the documentation links and GitHub install shorthand work for everyone.This PR description was generated by Pi using gpt-5.6-sol