fix(mgr): не грузить отсутствующий vue-dist/main.min.css на product/update - #504
Open
Ibochkarev wants to merge 1 commit into
Open
fix(mgr): не грузить отсутствующий vue-dist/main.min.css на product/update#504Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Vite never emits main.min.css; product-tabs already registers the needed CSS/JS. Drop unused main.min.js too. Closes #503.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
На странице редактирования товара менеджер запрашивал
css/mgr/vue-dist/main.min.css, которого Vite не создаёт (CSS выходит под именами исходников вродеprimeicons.min.css). В Network был 404.Убраны
addCss(main.min.css)и неиспользуемыйaddVueModule(main.min.js). Вкладки товара по-прежнему поднимаетproduct-tabsсprimeiconsиDynamicField.Тип изменений
Связанные Issues
Closes #503
Как это было протестировано?
Локальный CI-гейт:
composer test:smoke/composer test)Конфигурация тестирования:
fix/issue-503-main-min-cssотbetaЧеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue) — n/a, Vue не трогалиДополнительные заметки
Альтернатива из issue (фиксировать имя CSS в Vite для entry
main) не нужна:main.min.jsна этой странице ничего не монтирует, стили уже даётproduct-tabs.