Skip to content

Bug 2067851 - viaduct-hyper -> viaduct-backend-rust - #7596

Open
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-ptytrmmtrxxv
Open

Bug 2067851 - viaduct-hyper -> viaduct-backend-rust#7596
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-ptytrmmtrxxv

Conversation

@bendk

@bendk bendk commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The older hyper version we were using triggered RUSTSEC-2026-0258 when running cargo audit. I think switching back to reqwest makes more sense than upgrading to hyper 1.x Renamed the crate to viaduct-backend-rust since it's not using hyper anymore. See the bug comments for my reasoning around this.

I wasn't actually able to remove the RUSTSEC-2026-0258 exclusion, since nimbus-cli is still using hyper. However, I did remove the RUSTSEC-2018-0006 one. It's no longer needed since we're on clap v4.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk
bendk requested a review from mhammond September 10, 2026 17:33
@bendk
bendk requested a review from a team as a code owner September 10, 2026 17:33
@bendk
bendk requested review from Almaju and removed request for a team September 10, 2026 17:33
@bendk
bendk force-pushed the bdk/push-ptytrmmtrxxv branch from 7c0f05a to 5ef891f Compare September 10, 2026 17:39
@bendk

bendk commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

I don't love having to do this, but like I mentioned in the bug it would have also been a similar amount of work to upgrade to hyper 1.x. I'm thinking it's best to admit that using hyper was a mistake and go back to reqwest.

@bendk
bendk force-pushed the bdk/push-ptytrmmtrxxv branch 2 times, most recently from cee3e87 to 641d384 Compare September 10, 2026 19:39
@bendk

bendk commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

I ended up using reqwest 0.11 instead of 0.13 because I had issues with the dependency checks for 0.13. That made we wonder if this is the right solution going forward, but I still think it is because dependency checks are relatively simple to fix and we might not even have them once we move to the monorepo.

The older hyper version we were using triggered RUSTSEC-2026-0258 when
running `cargo audit`.  I think switching back to `reqwest` makes more
sense than upgrading to hyper 1.x Renamed the crate to
`viaduct-backend-rust` since it's not using `hyper` anymore. See the bug
comments for my reasoning around this.

I wasn't actually able to remove the `RUSTSEC-2026-0258` exclusion,
since nimbus-cli is still using hyper.  However, I did remove the
`RUSTSEC-2018-0006` one.  It's no longer needed since we're on clap v4.
@bendk
bendk force-pushed the bdk/push-ptytrmmtrxxv branch from 641d384 to 6b496ae Compare September 10, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant