Bug 2067851 - viaduct-hyper -> viaduct-backend-rust - #7596
Open
bendk wants to merge 1 commit into
Open
Conversation
bendk
force-pushed
the
bdk/push-ptytrmmtrxxv
branch
from
September 10, 2026 17:39
7c0f05a to
5ef891f
Compare
Contributor
Author
|
I don't love having to do this, but like I mentioned in the bug it would have also been a similar amount of work to upgrade to hyper 1.x. I'm thinking it's best to admit that using hyper was a mistake and go back to reqwest. |
bendk
force-pushed
the
bdk/push-ptytrmmtrxxv
branch
2 times, most recently
from
September 10, 2026 19:39
cee3e87 to
641d384
Compare
Contributor
Author
|
I ended up using reqwest 0.11 instead of 0.13 because I had issues with the dependency checks for 0.13. That made we wonder if this is the right solution going forward, but I still think it is because dependency checks are relatively simple to fix and we might not even have them once we move to the monorepo. |
The older hyper version we were using triggered RUSTSEC-2026-0258 when running `cargo audit`. I think switching back to `reqwest` makes more sense than upgrading to hyper 1.x Renamed the crate to `viaduct-backend-rust` since it's not using `hyper` anymore. See the bug comments for my reasoning around this. I wasn't actually able to remove the `RUSTSEC-2026-0258` exclusion, since nimbus-cli is still using hyper. However, I did remove the `RUSTSEC-2018-0006` one. It's no longer needed since we're on clap v4.
bendk
force-pushed
the
bdk/push-ptytrmmtrxxv
branch
from
September 10, 2026 19:47
641d384 to
6b496ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The older hyper version we were using triggered RUSTSEC-2026-0258 when running
cargo audit. I think switching back toreqwestmakes more sense than upgrading to hyper 1.x Renamed the crate toviaduct-backend-rustsince it's not usinghyperanymore. See the bug comments for my reasoning around this.I wasn't actually able to remove the
RUSTSEC-2026-0258exclusion, since nimbus-cli is still using hyper. However, I did remove theRUSTSEC-2018-0006one. It's no longer needed since we're on clap v4.Pull Request checklist
[ci full]to the PR title.