Skip to content

WebGLRenderer: Clean up transmission clear statements - #28449

Closed
gkjohnson wants to merge 2 commits into
mrdoob:devfrom
gkjohnson:small-transmission-cleanup
Closed

gkjohnson wants to merge 2 commits into
mrdoob:devfrom
gkjohnson:small-transmission-cleanup

Conversation

@gkjohnson

Copy link
Copy Markdown
Collaborator

Related issue: #28434 (comment)

Description

Ensure clear is not called twice.

@gkjohnson gkjohnson added this to the r165 milestone May 21, 2024
@gkjohnson
gkjohnson requested a review from Mugen87 May 21, 2024 12:14
@github-actions

github-actions Bot commented May 21, 2024 •

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.1 kB (168.3 kB) 679.1 kB (168.3 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.1 kB (110.3 kB) 457.1 kB (110.4 kB) -1 B

@Mugen87

Mugen87 commented May 21, 2024

Copy link
Copy Markdown
Collaborator

Already filed a PR here^^: #28447

@Mugen87 Mugen87 closed this May 21, 2024
@Mugen87 Mugen87 removed this from the r165 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants