Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNAME-only answers currently receive a 1,800-second cache lifetime, regardless of the CNAME TTL. Mixed CNAME/address answers can also remain cached after the shortest-lived record expires.
Use the minimum TTL across the cached answer section, then apply the configured minimum/maximum overrides. When no positive lifetime remains, discard the cached response (including any previous stale entry) instead of applying the arbitrary fallback. Custom static records remain untouched. This also keeps the cache usable after all dynamic entries have been discarded. Negative responses without answer records are left uncached; this does not add SOA-based negative caching.
Fixes #453.
Validation: the original implementation fails seven of the new wire-response TTL cases.
go test -race -p 2 ./... -count=1, 20 focused DNS race-test repetitions,go vet -p 2 ./...,go build -p 2 ./..., formatting and diff checks pass with Go 1.27.0 on Linux/amd64. Tests cover CNAME-only answers, mixed TTL order, zero TTLs, stale-entry replacement, minimum/maximum overrides, and an emptied cache; these are local DNS fixtures, not deployment testing.