fix: Do nothing w/debug checking if the core is already gone - #285
Open
mysterypaintwo wants to merge 1 commit into
Open
mysterypaintwo wants to merge 1 commit into
mysterypaintwo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
InteropDLL/DebugApiWrapper.cpp, every debugger call now goes through a check. If the core is already gone, the call does nothing instead of crashing.This was causing the program to crash unexpectedly on macOS Silicon systems.
Separately: I'd also like to bring attention to this separate issue, which I'm intentionally keeping off the repo: mysterypaintwo#1