Skip to content

permission: drop fs grants regardless of the path's current type - #66766

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:drop-fs-grants-regardless-of-the-path-s-current-ty
Nov 20, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:drop-fs-grants-regardless-of-the-path-s-current-ty

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

permission: drop fs grants regardless of the path's current type

Revoking a grant re-checked whether the path is a directory, so a path
that changed type after startup no longer matched the stored grant and
the drop was a silent no-op. Match both the plain and the wildcard form.

Revoking a grant re-checked whether the path is a directory, so a path
that changed type after startup no longer matched the stored grant and
the drop was a silent no-op. Match both the plain and the wildcard form.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (782a3ac) to head (5f4fc98).
⚠️ Report is 579 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/fs_permission.cc 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66766      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.02%     
==========================================
  Files         791      797       +6     
  Lines      277225   277599     +374     
  Branches    53313    53331      +18     
==========================================
+ Hits       250829   251224     +395     
+ Misses      16801    16793       -8     
+ Partials     9595     9582      -13     
Files with missing lines Coverage Δ
src/permission/fs_permission.cc 77.72% <78.57%> (+1.05%) ⬆️

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a506755 into nodejs:main Nov 20, 2026
88 of 89 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a506755

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants