Skip to content

src,permission: throw remaining fs errors async - #67037

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:src-permission-throw-remaining-fs-errors-async
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:src-permission-throw-remaining-fs-errors-async

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

src,permission: throw remaining fs errors async

These APIs were missed in https://github.com/nodejs/node/pull/52730.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (f0eb690) to head (66a6f7a).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 11.11% 0 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67037      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.01%     
==========================================
  Files         801      801              
  Lines      280944   280898      -46     
  Branches    54264    54251      -13     
==========================================
- Hits       254876   254821      -55     
+ Misses      16255    16249       -6     
- Partials     9813     9828      +15     
Files with missing lines Coverage Δ
src/node_file.cc 76.84% <11.11%> (-0.14%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

These APIs were missed in nodejs#52730.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS force-pushed the src-permission-throw-remaining-fs-errors-async branch from 07f3055 to 66a6f7a Compare November 20, 2026 01:44
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants