Repository navigation
net: validate onread buffers before each read - #67407
fatihguzeldev wants to merge 1 commit into
Conversation
an onread buffer can be detached after registration while native code still holds its address. validate the current view before each read and report an error instead of writing into the former backing store. Fixes: nodejs#67397 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67407 +/- ##
==========================================
- Coverage 90.72% 90.69% -0.04%
==========================================
Files 798 801 +3
Lines 280102 281589 +1487
Branches 53896 54254 +358
==========================================
+ Hits 254135 255385 +1250
- Misses 16252 16351 +99
- Partials 9715 9853 +138
🚀 New features to boost your workflow:
|
|
could someone share what failed in the windows and linux linked icu jobs? i can see both failures on github, but i don’t have access to the jenkins logs. |
As mentioned in Slack, I've requested
resume-ci
|
|
https://ci.nodejs.org/job/node-test-pull-request/79359/ In this run there are no failures for Windows failed in a different way and the job hung for several hours I'm trying a third run. |
socket reads can modify an immutable arraybuffer created by transferring
a registered onread buffer, because native code keeps the old address.
fail the read with a socket error when the view is no longer writable.
buffer factories can still supply a replacement and continue reading.
fixes #67397