Skip to content

doc,test: clarify http1 insecure validation - #67560

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:http-insecure-validation
Nov 20, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ethan-Arrowood:http-insecure-validation

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The httpValidation docs said 'insecure' disables all header value validation. That wasn't entirely true. It only did so for incomming messages (which are parsed with all --insecure-http-parser leniency flags). Outgoing header values are still validaed as in 'relaxed' mode. This comes from the design in #61597

This change corrects the docs and adds some tests to assert the expected behavior

Refs: #61597
Refs: #63571

AI-assisted (Claude Opus 5.5, my setup). The words are my own, per the Human Voice policy.

The httpValidation docs said 'insecure' disables all header value
validation. That wasn't entirely true. It only did so for incomming
messages (which are parsed with all --insecure-http-parser leniency
flags). Outgoing header values are still validaed as in 'relaxed'
mode. This comes from the design in nodejs#61597

This change corrects the docs and adds some tests to assert the
expected behavior

Refs: nodejs#61597
Refs: nodejs#63571
Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (a625b01) to head (250c08f).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67560      +/-   ##
==========================================
- Coverage   92.73%   90.72%   -2.02%     
==========================================
  Files         431      801     +370     
  Lines      196041   280686   +84645     
  Branches    30082    54156   +24074     
==========================================
+ Hits       181800   254647   +72847     
- Misses      13916    16202    +2286     
- Partials      325     9837    +9512     

see 514 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 17dab26 into nodejs:main Nov 20, 2026
72 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 17dab26

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants