Repository navigation
Conversation
The test checks watcher reference handling and process exit, not the absence of filesystem events. Do not fail on incidental change events. Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
inoway46
marked this pull request as ready for review
November 20, 2026 09:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67644 +/- ##
==========================================
+ Coverage 90.71% 90.73% +0.01%
==========================================
Files 801 801
Lines 280906 280906
Branches 54246 54253 +7
==========================================
+ Hits 254834 254885 +51
+ Misses 16251 16207 -44
+ Partials 9821 9814 -7 🚀 New features to boost your workflow:
|
Collaborator
Collaborator
lpinca
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test checks watcher ref/unref behavior and process exit, so incidental filesystem change events should not make it fail. Remove the
mustNotCall()listener.On both macOS and Linux, injecting a metadata change caused 1,000/1,000 failures before the fix and 0/1,000 after. Plain and CPU-load runs passed 1,000/1,000 before and after; the original CI failure did not reproduce naturally.
Original CI failure: https://github.com/nodejs/node/actions/runs/44653939632/job/136016285482
Validation: https://github.com/inoway46/node/actions/runs/44704450587