Skip to content

test: allow change events in fs watcher ref/unref test - #67644

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/deflake-fs-watch-ref-unref
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/deflake-fs-watch-ref-unref

Conversation

@inoway46

Copy link
Copy Markdown
Contributor

This test checks watcher ref/unref behavior and process exit, so incidental filesystem change events should not make it fail. Remove the mustNotCall() listener.

On both macOS and Linux, injecting a metadata change caused 1,000/1,000 failures before the fix and 0/1,000 after. Plain and CPU-load runs passed 1,000/1,000 before and after; the original CI failure did not reproduce naturally.

Original CI failure: https://github.com/nodejs/node/actions/runs/44653939632/job/136016285482
Validation: https://github.com/inoway46/node/actions/runs/44704450587

The test checks watcher reference handling and process exit, not the
absence of filesystem events. Do not fail on incidental change events.

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Assisted-by: Codex
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 20, 2026
@inoway46 inoway46 added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Nov 20, 2026
@inoway46
inoway46 marked this pull request as ready for review November 20, 2026 09:22
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.73%. Comparing base (50ba1ec) to head (287c47a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67644      +/-   ##
==========================================
+ Coverage   90.71%   90.73%   +0.01%     
==========================================
  Files         801      801              
  Lines      280906   280906              
  Branches    54246    54253       +7     
==========================================
+ Hits       254834   254885      +51     
+ Misses      16251    16207      -44     
+ Partials     9821     9814       -7     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christianaurichzm christianaurichzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christianaurichzm christianaurichzm added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@inoway46 inoway46 added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 20, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@christianaurichzm christianaurichzm added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants