Skip to content

sqlite: mark as stable - #67654

Open
christianaurichzm wants to merge 1 commit into
nodejs:mainfrom
christianaurichzm:sqlite-mark-stable
Open

christianaurichzm wants to merge 1 commit into
nodejs:mainfrom
christianaurichzm:sqlite-mark-stable

Conversation

@christianaurichzm

@christianaurichzm christianaurichzm commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

node:sqlite has been a release candidate since #61262, where @cjihrig asked for a decision on the async API before marking it stable. I followed up after the rename in #65988 and got the go-ahead. I also flagged #67353 and #67427 there, since some of their options would be semver-major after this.

The CLI docs drop "experimental" from the --no-experimental-sqlite description, as #45684 did for fetch. Making --experimental-sqlite a no-op is semver-major, so that'll be a separate PR.

Thanks @TrevorBurnham for the checklist in #57445, @araujogui and @trivikr for keeping it updated, and everyone who worked on node:sqlite.


Notable change

The built-in node:sqlite module is now stable, after being a release candidate since v25.7.0 and v24.15.0. It lets applications work with SQLite databases without installing a native addon.


Fixes: #57445

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 20, 2026
Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
@christianaurichzm christianaurichzm added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @christianaurichzm.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove experimental option altogether

Ref: #66431

@christianaurichzm

Copy link
Copy Markdown
Member Author

Done, thanks. It’s --no-sqlite now and --no-experimental-sqlite keeps working as a legacy alias.

@christianaurichzm christianaurichzm added needs-ci PRs that need a full CI run. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Nov 20, 2026
@trivikr
trivikr requested review from cjihrig and mcollina November 20, 2026 16:28

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we need --no-sqlite?

@christianaurichzm

Copy link
Copy Markdown
Member Author

Fair point, I don’t see a strong reason to keep an opt-out once it’s stable. Removing it is semver-major though, like #65284 was for WebSocket. Would you and @trivikr be OK with this PR only marking it stable, without the new flag, and a separate semver-major PR removing --no-experimental-sqlite?

@aduh95

aduh95 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Yep, I'd much prefer a doc-only change here, and making --experimental-sqlite a no-op undocumented flag can be a separate semver-major PR

@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (5884b8e) to head (eba104e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67654      +/-   ##
==========================================
- Coverage   90.71%   90.60%   -0.12%     
==========================================
  Files         801      801              
  Lines      280906   280969      +63     
  Branches    54249    54228      -21     
==========================================
- Hits       254832   254577     -255     
- Misses      16246    16576     +330     
+ Partials     9828     9816      -12     
Files with missing lines Coverage Δ
lib/internal/bootstrap/realm.js 97.09% <100.00%> (+0.58%) ⬆️
src/node_options.cc 88.26% <100.00%> (+0.02%) ⬆️
src/node_options.h 95.76% <100.00%> (ø)

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christianaurichzm christianaurichzm removed lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Nov 20, 2026
@christianaurichzm

Copy link
Copy Markdown
Member Author

Done, it’s back to the doc-only change. I’ll open the semver-major PR for --experimental-sqlite once this one lands.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for Jenkins CI on a doc-only PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stabilization of node:sqlite module

7 participants