Repository navigation
dgram: fix abort on negative zero buffer size - #67662
JuHyeong424 wants to merge 1 commit into
Conversation
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
The size check accepts -0, but the binding asserts IsUint32(), which V8 reports as false for -0, so setRecvBufferSize(-0) and setSendBufferSize(-0) abort the process. Coerce the value to +0. Signed-off-by: JuHyeong424 <wkdwngud963@gmail.com>
f7c620c to
c49a653
Compare
|
The recommendations in: advise you should tackle only one issue at a time and that you should not open any new PRs until your first PR has been approved. You already have another unapproved PR #67661 open at this time which was opened a few minutes before this one. Until the first PR has been approved and has landed in the Waiting until the first PR has landed ensures that you as a contributor have experienced the complete process from PR submission to successful landing. After this has been completed, any new PRs or new commits to an existing PR are treated to rules for regular Contributors. GitHub Actions CI workflows are then run automatically without intervention by a team member. |
Thanks for the explanation. I’ve converted this to a draft and will mark it ready after #67661 lands. |
The size check accepts -0, but the binding asserts IsUint32(), which V8 reports as false for -0, so setRecvBufferSize(-0) and setSendBufferSize(-0) abort the process. Coerce the value to +0.
Reproduction
On v26.13.1:
setSendBufferSize(-0)aborts the same way. The abort cannot be caught with try/catch.Same class of fix as #65888 (fs), #67651 (os) and #67661 (tls).
Added
test/parallel/test-dgram-negative-zero.js.