Skip to content

fix(cmake): use lowercase package name for libuv - #329

Closed
tbhaxor wants to merge 1 commit into
nodejs:mainfrom
tbhaxor:fix/libuv
Closed

tbhaxor wants to merge 1 commit into
nodejs:mainfrom
tbhaxor:fix/libuv

Conversation

@tbhaxor

@tbhaxor tbhaxor commented Nov 16, 2026

Copy link
Copy Markdown

find_package() looks for Config.cmake or -config.cmake. libuv installs libuvConfig.cmake, which only matches when the package is requested as "libuv". Using any other casing (e.g. LibUV) fails during the wabt install.

find_package() looks for <PackageName>Config.cmake or
<lowercasePackageName>-config.cmake. libuv installs
libuvConfig.cmake, which only matches when the package is
requested as "libuv". Using any other casing (e.g. LibUV)
fails during the wabt install.
@tbhaxor

tbhaxor commented Nov 20, 2026

Copy link
Copy Markdown
Author

Closing it in favour of #313

@tbhaxor tbhaxor closed this Nov 20, 2026
@tbhaxor
tbhaxor deleted the fix/libuv branch November 20, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant