Conversation
nmap_scanner.py is self-contained module that scans devices with nmap and stores results in devices.metadata_json - get_devices_to_scan(): selects inspected devices that are due for a scan based on timestamp - run_nmap_on_device(): runs nmap (default -sV) and writes them to database No production code paths call this yet.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Adds nmap scanning to the core as a new background worker running next to the mDNS and SSDP scanners. Off by default and only runs if the user turns on the ENABLE_NMAP_SCAN setting. Results stored in existing metadata_json column.
New file nmap_scanner.py:
[more information to come]
Test plan
Run the same commands CI uses:
ruff check
pytest src/tests
Closing issues
...