Skip to content

remove global mutable state from parse module - #26

Merged
Rameen-Mahmood merged 1 commit into
mainfrom
fix/remove-global-state
Mar 27, 2026
Merged

Rameen-Mahmood merged 1 commit into
mainfrom
fix/remove-global-state

Conversation

@Rameen-Mahmood

@Rameen-Mahmood Rameen-Mahmood commented Mar 27, 2026 •

Copy link
Copy Markdown
Member

Changes

  • replaced module-level unresolvable_ips set with a local set created in main() and passed through enrich_hostnames and reverse_dns
  • eliminates shared mutable state that leaked between calls and was not thread-safe

Testing

  • all 27 tests pass
  • backwards compatible, existing callers do not need to change

@Rameen-Mahmood
Rameen-Mahmood force-pushed the fix/remove-global-state branch from f24f982 to e1d94f6 Compare March 27, 2026 14:54
@Rameen-Mahmood
Rameen-Mahmood merged commit a8a89d9 into main Mar 27, 2026
5 checks passed
@Rameen-Mahmood
Rameen-Mahmood deleted the fix/remove-global-state branch March 27, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant