fix: avoid forced Microsoft OAuth consent - #51
Merged
calvinmclean merged 1 commit intoSep 16, 2026
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated behavior and has focused regression coverage.
Pull request overview
Restricts Google-specific OAuth parameters to Google authorization endpoints, preventing forced Microsoft consent while preserving scopes and PKCE.
Changes:
- Detect Google endpoints by hostname before adding offline consent options.
- Add focused Microsoft, Google, generic-provider, and PKCE URL coverage.
File summaries
| File | Description |
|---|---|
pkg/providers/generic.go |
Applies provider-aware authorization options. |
pkg/providers/generic_test.go |
Verifies generated authorization parameters. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
calvinmclean
marked this pull request as ready for review
September 15, 2026 22:05
calvinmclean
force-pushed
the
fix/microsoft-consent-prompt
branch
from
September 15, 2026 22:47
147ee89 to
f6b2a56
Compare
thedadams
approved these changes
Sep 16, 2026
njhale
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft authorization requests inherited
prompt=consentfrom the generic provider, which can trigger an unnecessary "Approval required" flow even when tenant-wide admin consent already exists.This regressed in #13, when provider-specific authorization parameters were replaced with unconditional oauth2 options.
prompt=select_accountfor Microsoft so users can choose another account without forcing consentprompt=consentonly for Google's authorization endpoint, preserving its refresh-token behavioraccess_type=offline, requested scopes, and PKCE URL generation unchanged