Skip to content

Detector panel improvements - #175

Open
LDiazN wants to merge 15 commits into
mainfrom
170-detector-panel-improvements
Open

Detector panel improvements#175
LDiazN wants to merge 15 commits into
mainfrom
170-detector-panel-improvements

Conversation

@LDiazN

@LDiazN LDiazN commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  • Adds support for query arguments to autoload a detection
  • Shows all blocking types in several rows of the same chart
  • Adds debugging panel at the bottom with several debugging properties:
    • dataframe view
    • json view of the chart
    • png version of the chart
  • Marks which ASNs are triggering changepoints
  • Add additional information on hover
  • Adds link to detector panel from slack notifications

closes #170

@LDiazN LDiazN self-assigned this Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.00%. Comparing base (440ff2d) to head (7991755).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   77.87%   83.00%   +5.12%     
==========================================
  Files          33       89      +56     
  Lines        1939     5724    +3785     
==========================================
+ Hits         1510     4751    +3241     
- Misses        429      973     +544     
Flag Coverage Δ
oonidata 77.87% <ø> (ø)
oonipipeline 85.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LDiazN
LDiazN marked this pull request as ready for review August 10, 2026 11:48
@@ -536,7 +537,15 @@ def run_detector(
update_tables(db, updated_cusums, changepoints)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update_tables call needs to be removed when running the detector inside of the event detector panel.
Without doing so, if you are running the event detector with a user that has write capabilities on the production database, you will mistakenly override the production cusum state tables. When that happens the state will be that of the reproduced event, instead of being that of the live run, leading to potential inconsistencies.

The longer term correct fix for this, would be to make the whole event detection logic stateless without needing to have these state tables at all.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call is not present in the function that runs in the panel, that would be this one:

See:

return run_detector_for(*args, **kwargs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements for the event detector debug panel

2 participants