Repository navigation
Conversation
Raw values use a 5-minute chart resolution for formatting but have no fixed step, so gap filling would isolate every point. Add a breakAtGaps prop to TimeSeriesChart (default true) and disable it for raw values in the wizard.
🦋 Changeset detectedLatest commit: 47d8e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🤖 Mapsight review linksPreview for Suggested starting points from the changed files and their demo consumers:
Why these screens?
Count-aggregator demos use local mock data. Updated after successful deployments. The commit above identifies this preview; a newer build may still be running. |
Station select and result labels decided whether to hide the section description by rebuilding the formatted label string. Resolve labels into a name plus the disambiguating field instead, and format the string in one place. When the section description disambiguates, show it as the usual description text rather than appending it to the name. buildStationLabels keeps its signature.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves
TimeSeriesChartin@mapsight/count-aggregator-uiwhen several stations are compared.comparisonTooltip: "compact"shows a colour swatch, a short station identifier (originId, or#<id>when ambiguous or long) and the metric per series. Tooltip height and width are bounded on small screens and scroll for long comparisons. Default stays"full"; single-series charts keep full labels in either mode.mergeSeriesDatainserts null rows at the expected resolution step, so line and area charts break at missing buckets instead of joining straight across them. Gaps are omitted from tooltips and never become measurements. Calendar steps (daily through yearly) follow local dates. Expansion is capped at 5,000 rows plus one break marker for each remaining gap. Raw values have no fixed step, so the wizard keeps connecting them. The newbreakAtGapsprop (defaulttrue) lets directTimeSeriesChartconsumers turn gap breaks off for other irregular series.buildStationLabelsgives custom selectors the same labels.No
future.v8_*defaults changed.Verification
pnpm verify --filter=@mapsight/count-aggregator-ui: lint (one existing warning inresult-step.test.tsx), typecheck, 122 testspnpm --filter @mapsight/count-aggregator-ui buildpnpm run checkpnpm exec changeset status --since=origin/main