Skip to content

[CONTRACT] Proposed: /map_identity evidence for the active Nav2 map (N2) #34

Open

Description

@panthera-momagdii

Status: Proposed. The implementation direction for N2 is agreed; this request records the new loader-to-observer interface for review. It does not approve a schema or replace #27 / #28.

Plan and scope: N2 / platform #36, producer #73 and its first-map/restart regression. Add a topic, /map_identity, between the platform map loader and the site-status observer. No existing decisions-register value is being changed.

Problem: With profile A configured, an observer starting after a different map B was loaded can see B first, read A’s file from disk, and incorrectly report A as matched. Same geometry, the launch-time YAML path, or startup timing cannot establish which artifact was loaded.

Proposed contract:

  • A single loader owns the supported map-loading path, at boot and on reload. Start the map server empty. After a successful Nav2 LoadMap, publish the identity of the artifact actually requested: artifact hash, load generation, and fingerprint of the returned occupancy grid. A failed load must not publish a new verified identity.
  • Use transient-local durability on publisher and subscriber so a restarted observer can obtain the most recent identity. Define fingerprint inputs and generation/restart semantics consistently across both nodes in the implementing change.
  • The observer reports a map match only when the expected artifact hash and the live grid fingerprint both agree with the loader record. Keep the existing grid fingerprint for change detection. A missing/unavailable authoritative loader is unverified; a bypass loading a different grid invalidates a previous match. Equal grid contents alone cannot identify who called load_map; document or enforce the boundary on direct service access.

Compatibility and consumers: Additive loader-to-status interface. Update the interface definition, documentation, loader, status subscriber and corresponding tests together or link their PRs. This request does not itself change the existing NavigationStatus field layout or assign new reason codes. Startup without verified evidence must not grant readiness. This is map identity evidence, not physical safety acceptance.

Evidence for closure (profile expects A): verified cold boot with A matches after the first load; same-geometry B first does not match; a restarted observer with B active does not match; an out-of-band load of a different grid invalidates the match; loader unavailable is unverified. Exercise the real Nav2 load response and late-subscriber behavior as well as the producer regressions. Remove #73’s strict expected failure only once it passes normally.

Implementation: Kunal / navigation. Validation of the implementations: Mohamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions