Skip to content

C9: canonical radians, degrees only in the LeRobot adapter profile (Proposed, #41) - #42

Draft
BotshareAI wants to merge 1 commit into
mainfrom
c9/canonical-radians
Draft

BotshareAI wants to merge 1 commit into
mainfrom
c9/canonical-radians

Conversation

@BotshareAI

@BotshareAI BotshareAI commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Proposed implementation of contract change request #41: C9 joint units are radians (rad/s for rates, m for the lift, m/s and rad/s for the base). Degrees remain only in the LeRobot bi-OpenArm adapter profile lerobot-v0.6.1-bi-openarm-position, converted at the adapter boundary. Status: Proposed. Draft until the software lead accepts or rejects #41.

  • Schema: vectorFeature gets an if/else: when profile is not the adapter profile, a dimension unit of degree, degrees, deg, deg/s or degree/s is rejected. The v1 shape is unchanged.
  • Fixtures: new valid schemas/yaml/c9-lerobot-dataset-valid-canonical-radians.yaml (the existing valid document with a canonical profile id and rad); new invalid schemas/json/c9-lerobot-dataset-invalid-degrees-outside-adapter-profile.json (degrees under a non-adapter profile id). Both registered in schemas/validation.json. The existing adapter fixture stays valid.
  • Docs: canonical-units paragraph in docs/c9-lerobot-dataset-contract.md; STATE.md row.

Precondition block

  • Repository: openAMRobot/openamrobot-interfaces
  • Branch: c9/canonical-radians (new)
  • Parent SHA: 50ed777be7990edbd3465f33fd97a158e7e3b88b (main)
  • Expected outcome: one draft PR, Proposed, no merge.

Base and head

  • Base: main at 50ed777be7990edbd3465f33fd97a158e7e3b88b
  • Head: 288a7f34ad3cea4f71778d608dcd1e30462ba2d8

Work package

Contract change request #41 (C9, follows #18). Consumers are listed in #41.

Tests

Commands, from the checkout (Python 3.12, jsonschema 4.26.0; ROS 2 Jazzy not installed locally):

python3 -c "import sys,json; from pathlib import Path; sys.path.insert(0,'tools'); from lint_schemas import validate_schemas; print(validate_schemas(Path('.')))"
  • At head: {"status": "PASS", "schemas": 1, "assets": 12, "reason": "Validated declared contracts"} (2 valid and 9 invalid C9 fixtures plus the other registered assets).
  • Revert run (schema from main, new fixtures kept): ValueError: Invalid fixture unexpectedly accepted: schemas/json/c9-lerobot-dataset-invalid-degrees-outside-adapter-profile.json. The rule is what rejects the fixture.
  • python3 -m pytest -q tests/test_schema_validation.py: 12 passed, 3 failed with ModuleNotFoundError: rosidl_adapter (ROS-only interface lint tests). Same 3 fail on main locally, so they are environment failures, not results. The hosted ROS 2 Jazzy workflow (tools/verify.sh) on this PR is the evidence for them.

Not verified

Integration Gate

Dependencies

None changed.

AI disclosure

Claude Code (Claude Opus 5.5) wrote the schema rule, both fixtures (derived mechanically from the existing valid fixture), the doc paragraph and this description, and ran the commands above. Reviewed by: pending (software lead).

https://claude.ai/code/session_01DZnPEMPDB6f8AohTTfGWkF


Generated by Claude Code

…roposed, #41)

The schema rejects a degree unit in a vector feature whose profile is not
lerobot-v0.6.1-bi-openarm-position. A canonical radian valid fixture and a
degrees-outside-adapter invalid fixture are registered. Proposed until the
software lead accepts contract change request #41.

Signed-off-by: Alex Reznichenko <info@botshare.ai>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant