Repository navigation
C9: canonical radians, degrees only in the LeRobot adapter profile (Proposed, #41) - #42
Draft
BotshareAI wants to merge 1 commit into
Draft
BotshareAI wants to merge 1 commit into
BotshareAI wants to merge 1 commit into
Conversation
…roposed, #41) The schema rejects a degree unit in a vector feature whose profile is not lerobot-v0.6.1-bi-openarm-position. A canonical radian valid fixture and a degrees-outside-adapter invalid fixture are registered. Proposed until the software lead accepts contract change request #41. Signed-off-by: Alex Reznichenko <info@botshare.ai> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposed implementation of contract change request #41: C9 joint units are radians (rad/s for rates, m for the lift, m/s and rad/s for the base). Degrees remain only in the LeRobot bi-OpenArm adapter profile
lerobot-v0.6.1-bi-openarm-position, converted at the adapter boundary. Status: Proposed. Draft until the software lead accepts or rejects #41.vectorFeaturegets anif/else: whenprofileis not the adapter profile, a dimension unit ofdegree,degrees,deg,deg/sordegree/sis rejected. The v1 shape is unchanged.schemas/yaml/c9-lerobot-dataset-valid-canonical-radians.yaml(the existing valid document with a canonical profile id andrad); new invalidschemas/json/c9-lerobot-dataset-invalid-degrees-outside-adapter-profile.json(degrees under a non-adapter profile id). Both registered inschemas/validation.json. The existing adapter fixture stays valid.docs/c9-lerobot-dataset-contract.md; STATE.md row.Precondition block
c9/canonical-radians(new)50ed777be7990edbd3465f33fd97a158e7e3b88b(main)Base and head
mainat50ed777be7990edbd3465f33fd97a158e7e3b88b288a7f34ad3cea4f71778d608dcd1e30462ba2d8Work package
Contract change request #41 (C9, follows #18). Consumers are listed in #41.
Tests
Commands, from the checkout (Python 3.12, jsonschema 4.26.0; ROS 2 Jazzy not installed locally):
{"status": "PASS", "schemas": 1, "assets": 12, "reason": "Validated declared contracts"}(2 valid and 9 invalid C9 fixtures plus the other registered assets).main, new fixtures kept):ValueError: Invalid fixture unexpectedly accepted: schemas/json/c9-lerobot-dataset-invalid-degrees-outside-adapter-profile.json. The rule is what rejects the fixture.python3 -m pytest -q tests/test_schema_validation.py: 12 passed, 3 failed withModuleNotFoundError: rosidl_adapter(ROS-only interface lint tests). Same 3 fail onmainlocally, so they are environment failures, not results. The hosted ROS 2 Jazzy workflow (tools/verify.sh) on this PR is the evidence for them.Not verified
bash tools/verify.shlocally (needs ROS 2 Jazzy). Hosted checks on head288a7f3: repository-quality, quality/test, quality/build and DCO passed.87ab8a9; no consumer is repinned here.contract_versionstays 1 (proposed) or moves to 2: software lead.Integration Gate
rad; no file overlap with this PR exceptdocs/c9-lerobot-dataset-contract.md(C9: proposed additive component mapping and model compatibility checks #39 changes one line there; this PR does not touchprofiles/c9/). [INTERFACE] C9 LeRobotDataset capture metadata contract acceptance #18 (closed) is the C9 v1 request this follows.tools/lint_schemas.pyand fixture registry, unchanged.Dependencies
None changed.
AI disclosure
Claude Code (Claude Opus 5.5) wrote the schema rule, both fixtures (derived mechanically from the existing valid fixture), the doc paragraph and this description, and ran the commands above. Reviewed by: pending (software lead).
https://claude.ai/code/session_01DZnPEMPDB6f8AohTTfGWkF
Generated by Claude Code