Repository navigation
test: prepare installed consumer checks for interfaces contract 2 - #16
KARTHIKEYAN124 wants to merge 11 commits into
Conversation
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
panthera-momagdii
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES (P2, installed-interface evidence can overcount a repeated built-in message) — focused source/evidence review of this draft test-only contract-2 fixture at head f121c4496edfc4ee9ca66d75f9065002c34b4034. No release repin, contract adoption, or acceptance is authorized.
In scripts/validate_navigation_install.py::main(), the new additional_messages check rejects repetitions inside the extra list, but not an extra name already in the 11-message baseline or contract-2's SiteConfigStatus. In scripts/nav-install/verify-nav-generated.py, NAMES += ...EXTRA_MESSAGES then tests the same existing type twice. Finally generated_messages_verified = (12 if contract_version == 2 else 11) + len(additional) credits that duplicate as an additional verified type.
Reproduction (independent isolated Python control-flow check, RUN; no Docker/ROS): with contract 2 and additional_messages: ["NavigationStatus"] (or ["SiteConfigStatus"]), the exact preflight name/uniqueness conditions accept the manifest; the verifier's resulting inventory contains 13 entries but only 12 distinct message names; the evidence counter would claim 13. ["MapIdentity"], the current fixture, is distinct and correctly produces 13, so I am not disputing the current MapIdentity serialization evidence.
Please reject intersections of additional_messages with the contract-specific built-in inventory before Docker, add negative tests for both NavigationStatus and SiteConfigStatus plus a positive MapIdentity control, and keep the evidence count tied to a validated unique inventory.
Inspected CI, not run by me: exact-head hosted pinned rc.1 and navigation-install workflows passed (navigation-install run 42575246993); repository quality passed while shared quality/test was skipped. NOT RUN: independent Docker/ROS install, full candidate build, hardware or end-to-end producer verification. The PR's draft status, upstream contract #34/author DCO, package-version, #12 and Gate A release gates must remain intact.
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
panthera-momagdii
left a comment
There was a problem hiding this comment.
COMMENT - incremental re-review from f121c44 to exact head 56c79d0.
The previous duplicate-inventory finding is fixed. Preflight and the installed verifier now use one shared inventory; extras must be unique and disjoint from contract-specific built-ins; invalid overlaps are rejected before evidence-directory creation or Docker; the verifier's exact list must match preflight and the count comes from that verified list. Regression tests reject NavigationStatus and SiteConfigStatus overlaps and retain the positive MapIdentity control.
I independently reproduced the inventory checks in Python: 11/12 built-ins and 13 distinct types with MapIdentity; the duplicate cases reject. Exact-head hosted navigation-install run 42675041028 passed 44 tests with zero skips and completed two independent producer/consumer pairs for contract 1 and the contract-2 fixture. Pinned-release run 42675040818 passed two independent source builds and checksum verification. Repository-quality governance passed; shared quality/test was skipped. license/cla is green and the latest commit has a DCO sign-off. I did not run local Docker/ROS.
This clears my prior P2 finding, not release approval. Keep this PR draft. Release #12 is still open; interfaces #28 and platform-sw #73 are still open; contract #34 remains Proposed; package-version/repin and Gate A acceptance remain unresolved. No release pin, contract adoption or merge is approved.
Work package
Prepare source-free installed-consumer validation for a separate interfaces repin. Explicit package/contract expectations replace the old consumer hardcoding. The existing contract-1 pin remains unchanged; a clearly labelled test-only contract-2 fixture targets interfaces #28 at fbb7b3f93a2024b4d48a2d02f1e531da17b8f8e9 in the author's fork, with its actual package version 0.0.0. No release pin or source checksum changes.
Integration Gate
Depends on release #12 merging first; this draft currently includes its commits. Preparation-only diff starts at e7a41dd. Update against main after #12 merges before owner adoption/review.
The installed C++ consumer exercises SiteConfigStatus for contract 2. Python type-support checks include the explicit additional MapIdentity message. Each contract uses two independent producer/consumer pairs with source unavailable to consumers and absent-install negative controls. Installation evidence does not accept proposed MapIdentity contract #34 or the runtime producer.
P2 review correction
Addresses #16 (review).
Both preflight and the installed verifier now use scripts/nav-install/message_inventory.py as the single inventory definition. Extras must be unique and disjoint from the contract-specific built-ins: NavigationStatus is rejected for both contracts; SiteConfigStatus is rejected for contract 2. This occurs before Docker or evidence-directory creation.
After native serialization checks, the consumer writes verified-messages.json. The runner requires exact equality with its preflight inventory, records the verified names, and derives generated_messages_verified from that list's length. There is no base-count-plus-extras arithmetic. The MapIdentity fixture remains 13 distinct navigation messages.
Tests
Preparation base: e7a41dd
Review-fix parent: f121c44
Current head: 56c79d0
python -m unittest discover -s tests -v: 44 tests pass, zero skips.git diff --check: passes.Before the fix, the newly added overlap regression methods errored in three subcases because invalid manifests passed preflight and reached mocked Docker/build handling. After the fix all reject with exit 2 before any subprocess and before creating evidence. Positive controls verify 11/12 distinct built-ins and 13 distinct contract-2 types with MapIdentity.
Fresh hosted checks:
Dependencies
No new dependencies or upstream code copied. The test fixture references MIT interfaces source by exact SHA. No licence, NOTICE or CODEOWNERS changes.
STATE.md
Records fixture readiness, the shared unique inventory, regression evidence and unresolved owner/author requirements.
Not verified
Local Docker is unavailable; fresh ROS validation relies on hosted runs. Contract #34 is still Proposed, interfaces #28 needs author DCO remediation and its stale compatibility snapshot corrected, numeric release package versions are not approved, and platform-sw #73 producer/observer acceptance remains open. Companion snapshot-only fix is offered in skunal3318/openamrobot-interfaces#1.
No final repin, Gate A acceptance, full-workspace build, runtime producer acceptance, safety or physical hardware claim. Draft status remains intact; release #12 and all owner/author acceptance gates remain required. The four-component refresh remains separate from interfaces repinning.
AI disclosure
OpenAI Codex prepared the consumer parameterization, test-only fixture, shared inventory fix, regression tests and evidence notes under contributor direction. Commits use the authenticated contributor's existing DCO identity; no other contributor's sign-off or owner approval is asserted. Draft pending adoption and dependencies.