Skip to content

fix: accept canonical ClawSweeper comment commands - #4

Merged
steipete merged 1 commit into
openclaw:mainfrom
SebTardif:fix/comment-prefilter-commands
Oct 16, 2026
Merged

steipete merged 1 commit into
openclaw:mainfrom
SebTardif:fix/comment-prefilter-commands

Conversation

@SebTardif

@SebTardif SebTardif commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

What changes

Ignore marked maintainer opt-in reminders before matching command text, so quoted commands do not create another dispatch. Keep the existing shared-router command set unchanged. Add regression tests that execute the workflow's actual prefilter shell, document the behavior, and thank @SebTardif in the changelog.

Validation

The reminder regression failed on the previous main branch and passed with the guard. All 31 tests passed locally and on Linux Crabbox; actionlint passed; independent Codex review found no actionable P0–P2 defects.

Exact-head Actions: https://github.com/openclaw/clawsweeper.bot/actions/runs/38954619857

Merged as 36005e7. Original contributor-hosted proof remains available at https://github.com/SebTardif/clawsweeper.bot/actions/runs/38833517729.

@clawsweeper

clawsweeper Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

@SebTardif is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Oct 16, 2026
@clawsweeper

clawsweeper Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR prevents marked maintainer opt-in reminders from triggering comment-command dispatch.

Example: A comment contains <!-- clawsweeper-maintainer-opt-in:opened item=42 --> followed by /review.

  • Before: The prefilter admits the reminder and starts the acknowledgement and dispatch step.
  • After: The prefilter rejects the reminder and skips that step.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, correct fix supported by hosted workflow evidence and regression coverage.
Proof confidence 🐚 platinum hermit (4/6) ✨ media proof bonus Sufficient (linked_artifact): Current-head GitHub-hosted issue-comment runs exercise the actual workflow prefilter and show reminder suppression, ordinary-candidate admission, and unsupported-form rejection. The supplied output identifies the unchanged missing-credential exit; credentialed downstream dispatch is outside this guard's behavior.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: A bot reminder containing command text starts another command-dispatch attempt.
Reason: Suppressing explicitly marked reminders restores the established dispatcher behavior without changing user commands or defaults.

Merge readiness

✅ Ready for maintainer review

This PR fixes a current prefilter defect with a focused guard; the earlier unsupported-alias finding is resolved, and no blocking code findings remain.

Priority: P2
Reviewed head: 688c5bf95d528ce3012ccb96448786d12516d2ed

Before merge

None.

Findings

None.

Agent review details

How this fits together

The GitHub Actions dispatcher receives issue comments, filters command candidates, and forwards admitted comments to the shared ClawSweeper router.

flowchart TD
  A[GitHub issue comment] --> B[Comment prefilter]
  B --> C[Marked reminder ignored]
  B --> D[Command candidate]
  D --> E[Acknowledgement and dispatch]
  E --> F[Shared ClawSweeper router]
Loading

Technical review

Best possible solution:

Land the narrow reminder guard while preserving the existing command set.

Do we have a high-confidence way to reproduce the issue?

Main's expression admits a reminder containing a separate /review line, and no marker guard prevents the resulting dispatch path.

Is this the best way to solve the issue?

The guard matches the shared dispatcher's established behavior and addresses the cause without expanding command support.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 13419ce4ddee.

Provenance checked

  • Comment prefilter keeps the original intent (adca467: The original workflow filters command candidates before acknowledgement and forwarding; the new guard preserves that purpose while excluding generated reminders.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit adca467 adds .github/workflows/clawsweeper-dispatch.yml:42 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: adca46792e86; files: .github/workflows/clawsweeper-dispatch.yml)
  • Sebastien Tardif: Raw commit 13419ce adds .github/workflows/clawsweeper-dispatch.yml:15 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 13419ce4ddee; files: .github/workflows/clawsweeper-dispatch.yml)

Labels

Label changes:

  • add proof: sufficient: Contributor real behavior proof is sufficient.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • remove rating: 🦪 silver shellfish: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
  • remove status: 📣 needs proof: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

  • P2: The defect queues unnecessary work for marked reminder comments, with limited blast radius.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)
  • reviewed 2026-10-16T01:04:12.192Z sha 4ee6f77 :: needs real behavior proof before merge. :: [P2] Ensure newly admitted aliases are parsed before queuing them

Reviewed October 15, 2026, 9:13 PM ET / October 16, 2026, 01:13 UTC (Revision 2).

@SebTardif

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Oct 16, 2026
Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
@steipete
steipete force-pushed the fix/comment-prefilter-commands branch from 688c5bf to 58e1b58 Compare October 16, 2026 19:23

@steipete steipete left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the regression on main and the fix at 58e1b58. The 31-test suite, actionlint, independent review, and exact-head Actions checks pass.

@steipete
steipete merged commit 36005e7 into openclaw:main Oct 16, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants