Repository navigation
fix: accept canonical ClawSweeper comment commands - #4
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
@SebTardif is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs maintainer review before merge. What this changesThis PR prevents marked maintainer opt-in reminders from triggering comment-command dispatch. Example: A comment contains
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR fixes a current prefilter defect with a focused guard; the earlier unsupported-alias finding is resolved, and no blocking code findings remain. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe GitHub Actions dispatcher receives issue comments, filters command candidates, and forwards admitted comments to the shared ClawSweeper router. flowchart TD
A[GitHub issue comment] --> B[Comment prefilter]
B --> C[Marked reminder ignored]
B --> D[Command candidate]
D --> E[Acknowledgement and dispatch]
E --> F[Shared ClawSweeper router]
Technical reviewBest possible solution: Land the narrow reminder guard while preserving the existing command set. Do we have a high-confidence way to reproduce the issue? Main's expression admits a reminder containing a separate Is this the best way to solve the issue? The guard matches the shared dispatcher's established behavior and addresses the cause without expanding command support. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 13419ce4ddee. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 15, 2026, 9:13 PM ET / October 16, 2026, 01:13 UTC (Revision 2). |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
688c5bf to
58e1b58
Compare
What changes
Ignore marked maintainer opt-in reminders before matching command text, so quoted commands do not create another dispatch. Keep the existing shared-router command set unchanged. Add regression tests that execute the workflow's actual prefilter shell, document the behavior, and thank @SebTardif in the changelog.
Validation
The reminder regression failed on the previous main branch and passed with the guard. All 31 tests passed locally and on Linux Crabbox; actionlint passed; independent Codex review found no actionable P0–P2 defects.
Exact-head Actions: https://github.com/openclaw/clawsweeper.bot/actions/runs/38954619857
Merged as 36005e7. Original contributor-hosted proof remains available at https://github.com/SebTardif/clawsweeper.bot/actions/runs/38833517729.