Repository navigation
rgbd: fix registerDepth with larger input depth - #4235
Open
sridhar-git05 wants to merge 1 commit into
Open
sridhar-git05 wants to merge 1 commit into
sridhar-git05 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Fixes #3761.
registerDepth()allocated the intermediatePoint3fbuffer usingoutputImagePlaneSize. When the input depth image was larger than therequested output image plane, the registration loop wrote one 3D point
for every input depth pixel, causing an out-of-bounds access.
Allocate the intermediate buffer using
unregisteredDepth.size()instead,so it contains one element for every input depth pixel.
Added a regression test covering a 1000x1000 depth image registered to a
300x300 output image.
Testing:
Rgbd_DepthRegistration.issue_3761.Rgbd_DepthRegistration.issue_3761passes with a Debug build of the rgbd module.git diff --checkpasses.