Repository navigation
Fix CUDA multiply and square integer overflow - #4242
Open
arcusbuilds wants to merge 1 commit into
Open
arcusbuilds wants to merge 1 commit into
arcusbuilds wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuda::multiply and cuda::sqr computed 16-bit products in int without saturating (65535*65535 gave 0) and wrapped 32S products written as CV_32F; this saturates the 16-bit results and computes 32S to float in double, while CV_32S output still wraps. Fixes #4213
Adds overflow regression tests to test_element_operations.cpp with literal 16-bit expected results.
Built with CUDA on sm_89 and ran the new tests plus the cudaarithm test suite.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.