Skip to content

Bugfix/add missing deletion workflow job - #81

Merged
sergio-soria-bi merged 5 commits into
masterfrom
bugfix/add-missing-deletionWorkflowJobId
Aug 21, 2026
Merged

Bugfix/add missing deletion workflow job#81
sergio-soria-bi merged 5 commits into
masterfrom
bugfix/add-missing-deletionWorkflowJobId

Conversation

@sergio-soria-bi

Copy link
Copy Markdown
Contributor

No description provided.

tags:
- ProvisionResults
summary: Request App Support to do operations to delete provision status component (and dependencies) from the file
summary: Delete a provision status component via AWX workflow

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the "status" word here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@Slf4j
public class ProvisionResultsApiFacade {

private static final String DELETION_WORKFLOW_ID = "deletion_workflow";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if, instead of defining private variables (in multiple places currently? idk), we put these parameter names inside a class that represents the Provision action, or has something to do with it? This way we could centralize the information regarding this, and avoid having defined n times the same vars in different places.

This is more an idea than a suggestion for now, we could do it asap or we could open a task for it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, it is only used in here, I have basically to remove it in the other place.

@sonarqubecloud

Copy link
Copy Markdown

@ivan-risueno
ivan-risueno self-requested a review August 21, 2026 09:29
@sergio-soria-bi
sergio-soria-bi merged commit abb5f93 into master Aug 21, 2026
3 checks passed
@sergio-soria-bi
sergio-soria-bi deleted the bugfix/add-missing-deletionWorkflowJobId branch August 21, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants