Add an object name to the identify tool item for plugins to access - #8052
Merged
Merged
Conversation
Collaborator
🪟 Windows buildsDownload a Windows build of this PR for testing and for arm64. (Built from commit 7e8212c) 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures |
MidnightCoder-m
approved these changes
Sep 25, 2026
MidnightCoder-m
left a comment
MidnightCoder-m
left a comment
Collaborator
There was a problem hiding this comment.
Just a Heads-up : now that plugins can reach this item, a plugin doing identifyTool.deactivated = ... breaks the binding. i think the old PropertyChanges reset it on the next state change. Probably fine .. just worth noticing.
Member
Author
|
@MidnightCoder-m , it's not fine no. If the plugin wants to be in charge of identification, changing the state shouldn't overwrite it. It's up to the plugin to properly rebind when the plugin unloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #8051 (wouldn't backport due to property name change)