Skip to content

Fix inverted lighting on 3D polygon fills and walls - #8054

Merged
nirvn merged 1 commit into
masterfrom
3d-polygon-face-orientation
Sep 26, 2026
Merged

nirvn merged 1 commit into
masterfrom
3d-polygon-face-orientation

Conversation

@MidnightCoder-m

@MidnightCoder-m MidnightCoder-m commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

🚀 Description

Polygon fills in the 3D map view were facing down, so the top side got lit from below and looked grey. This fixes the mesh orientation and drops the no-lighting workaround.

✨ Key changes

  • Polygon fill triangles always face up, whatever the ring orientation
  • Extruded walls always face outward
  • Removed lighting: NoLighting from the highlight and plugin geometry materials

Demo

front back
image image

@MidnightCoder-m MidnightCoder-m self-assigned this Sep 25, 2026
@qfield-fairy

qfield-fairy commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

🍎 MacOS DMG universal builds

Download a MacOS DMG universal build of this PR for testing.
(Built from commit f78bd64)

🪟 Windows builds

Download a Windows build of this PR for testing and for arm64.

(Built from commit f78bd64)

📱 Android builds

Download an Android arm64 build of this PR for testing.
(Built from commit f78bd64)

Other Android architectures

🐧 Linux AppImage builds

Download a Linux AppImage build of this PR for testing.
(Built from commit f78bd64)

Comment thread src/3d/qf3dgeometryutils.cpp Outdated
@MidnightCoder-m
MidnightCoder-m force-pushed the 3d-polygon-face-orientation branch from aa1f2de to f78bd64 Compare September 25, 2026 18:08
@nirvn
nirvn merged commit 0376577 into master Sep 26, 2026
33 checks passed
@nirvn
nirvn deleted the 3d-polygon-face-orientation branch September 26, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants