Skip to content

Unify permission checks - #382

Open
vvmruder wants to merge 7 commits into
refactoringfrom
refactoring-unify-permission-checks
Open

vvmruder wants to merge 7 commits into
refactoringfrom
refactoring-unify-permission-checks

Conversation

@vvmruder

@vvmruder vvmruder commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Pull Request Template

Description

Centralizing the evaluation of access to layers as much as possible to minimize the ambiguity and enable possibility for automated testing.

This has effect on:

  • ogc maps endpoint (WMS/WFS)
  • ogc webgis endpoint (WMS/WFS)
  • ogcapi features endpoint

Added test coverage to prove and narrow how the permission choices are determined.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Definition of Done

For the developer

  • Code conforms to defined coding standards
  • Image builds in the CI are passing
  • If necessary (at the developer's discretion), unit tests have been added for critical parts.
    • All unit tests run without error.
  • Pull-Request contains a few explanations of what was done.
  • A reviewer has been assigned.
  • A tester has been assigned, if the GUI or a GUI related workflow logic is impacted by the PR (at the developer's discretion).

For the tester

Only required if relevant

  • The tester has successfully tested the new code on their development setup or on a suitable development server/devbox
  • The code can be merged (from a functional perspective)

For the code reviewer

Required in every case

  • New code was successfully reviewed
  • The reviewer fully understands the new code
  • If comments could be added on unclear code, the developer has been informed.
  • If unit tests could be added in certain places, the developer has been informed.
  • The reviewer has successfully tested the new code on their development setup or on a suitable development server/devbox
  • The code can be merged (from a code perspective)

Screenshots / Evidence (if applicable)

Related Issues

@vvmruder
vvmruder changed the base branch from master to refactoring September 25, 2026 17:15
@vvmruder
vvmruder marked this pull request as ready for review September 29, 2026 14:16
@vvmruder
vvmruder requested a review from oreilles September 29, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant