Clarify VC without Holder Binding is returned directly in the VP Token - #783
Open
jogu wants to merge 2 commits into
Open
Clarify VC without Holder Binding is returned directly in the VP Token#783jogu wants to merge 2 commits into
jogu wants to merge 2 commits into
Conversation
When require_cryptographic_holder_binding is false, implementers were unsure whether to return the bare W3C Verifiable Credential or a Verifiable Presentation envelope without a proof. Clarify that the Credential itself goes directly into the VP Token, and scope the nonce/aud and challenge/domain requirements in the jwt_vc_json and ldp_vc Presentation Response sections to the case where a Verifiable Presentation is returned. Fixes #742
Collaborator
|
discuss in WG: @brentzundel will review |
brentzundel
approved these changes
Aug 28, 2026
Sakurann
approved these changes
Aug 31, 2026
fkj
approved these changes
Aug 31, 2026
paulbastian
reviewed
Aug 31, 2026
c2bo
approved these changes
Sep 1, 2026
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When require_cryptographic_holder_binding is false, implementers were unsure whether to return the bare W3C Verifiable Credential or a Verifiable Presentation envelope without a proof. Clarify that the Credential itself goes directly into the VP Token, and scope the nonce/aud and challenge/domain requirements in the jwt_vc_json and ldp_vc Presentation Response sections to the case where a Verifiable Presentation is returned.
Fixes #742