Skip to content

OCPBUGS-103964:[release-4.20] Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame - #2381

Open
Pranavgarud06 wants to merge 1 commit into
openshift:release-4.20from
Pranavgarud06:CVE-2026-33814-release-4.20
Open

OCPBUGS-103964:[release-4.20] Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame#2381
Pranavgarud06 wants to merge 1 commit into
openshift:release-4.20from
Pranavgarud06:CVE-2026-33814-release-4.20

Conversation

@Pranavgarud06

@Pranavgarud06 Pranavgarud06 commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  1. Fixes CVE-2026-33814 (golang.org/x/net/http2 HTTP/2 client infinite-loop DoS on SETTINGS_MAX_FRAME_SIZE=0, GO-2026-4918, CVSS 7.5) on release-4.20
  2. Uses go mod edit -replace to pin golang.org/x/net to github.com/openshift-sustaining/net@v0.50.0-sec.4 (keeps go 1.24.0; the upstream fix in x/net v0.53.0 would force go 1.25.0)
  3. Ran go mod tidy, go mod vendor, and verified clean build with go build ./...

Test plan

  • go build ./... passes locally
  • govulncheck ./... no longer reports GO-2026-4918
  • CI passes

🤖 Generated with Claude Code

…use upstream fix (x/net v0.53.0) requires go 1.25.0
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Pranavgarud06: This pull request references Jira Issue OCPBUGS-103964, which is invalid:

  • expected Jira Issue OCPBUGS-103964 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  1. Fixes CVE-2026-33814 (golang.org/x/net/http2 HTTP/2 client infinite-loop DoS on SETTINGS_MAX_FRAME_SIZE=0, GO-2026-4918, CVSS 7.5) on release-4.20
  2. Uses go mod edit -replace to pin golang.org/x/net to github.com/openshift-sustaining/net@v0.50.0-sec.4 (keeps go 1.24.0; the upstream fix in x/net v0.53.0 would force go 1.25.0)
  3. Ran go mod tidy, go mod vendor, and verified clean build with go build ./...

Test plan

  • go build ./... passes locally
  • govulncheck ./... no longer reports GO-2026-4918
  • CI passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ee58389-54cc-4fd0-9c49-ef2176684619

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pranavgarud06
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@Pranavgarud06: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1b648c6 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants