Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

VIDCS-3882: ConnectionServices Kotlin sample - #548

Merged
VZaphod merged 30 commits into
mainfrom
VIDCS-3882
Nov 5, 2025
Merged

VZaphod merged 30 commits into
mainfrom
VIDCS-3882

Conversation

@VZaphod

@VZaphod VZaphod commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@VZaphod

VZaphod commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Fixed issues

@VZaphod VZaphod changed the title ConnectionServices Kotlin sample VIDCS-3882: ConnectionServices Kotlin sample Jun 30, 2025
@goncalocostamendes

Copy link
Copy Markdown
Contributor

Please add a workflow for both connection services samples https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows. It will just build the project so that we are at least aware it does not brake with future changes

@VZaphod

VZaphod commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Please add a workflow for both connection services samples https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows. It will just build the project so that we are at least aware it does not brake with future changes

Added!

@joliveraortega

Copy link
Copy Markdown
Contributor

@VZaphod 2.31.0 is out. We can go ahead and finish with this.

@VZaphod

VZaphod commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Looks like we can not inject the common gradle version into the toml. @manolovn do you know if we can use the

apply {
    from '../../commons.gradle'
}

approach using the toml?

Importing the OpenTok version from commons.gradle
@VZaphod

VZaphod commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

Extracted OpenTok dependency from the toml to the build.gradle.kts file so now can be updated with the commons.gradle file

@VZaphod

VZaphod commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

Solved merge conflict

@joliveraortega joliveraortega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Would you mind to have a look at the workflow that is failing please. Thanks!

@VZaphod
VZaphod merged commit e3d2b7b into main Nov 5, 2025
39 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants