ARCH/X86: Move AVX2 NT code and extract ERMS memcpy helper - #11878
Merged
Merged
Conversation
Move the existing AVX2 non-temporal buffer-transfer helpers from cpu.c to an ISA-specific inline fragment without changing their implementation or dispatcher behavior. Signed-off-by: Arun Chandran <Arun.Chandran@amd.com>
Move the existing rep movsb sequence into ucs_x86_memcpy_erms() and call it from the same built-in memcpy size window. Keep the compile guard and return semantics unchanged. Signed-off-by: Arun Chandran <Arun.Chandran@amd.com>
|
🤖 Starting review — findings will be posted here when done. |
Contributor
Author
|
@tvegas1 @roiedanino please check |
tvegas1
changed the title
tvegas1
approved these changes
Sep 2, 2026
roiedanino
approved these changes
Sep 2, 2026
Contributor
Author
|
Is this ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor the code
Why?
Feature: splitting as per comments from #11696
How?
#11696 will be broken into logical PRs, this is the first in the series