Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Frappe Charts with
@orchidsoftware/charts0.0.8 and let screens configure charts directly through the PHP layout API, without a dedicated chart class.The screen query supplies shared labels and datasets:
Changes
orchid:chartgenerator to the new PHP API and data format.Breaking changes
labelsanddatasets; labels inside individual datasets are no longer the supported format.TimeCollection::toChart()andGroupCollection::toChart()return the new shape.TYPE_MIXEDreplacesTYPE_AXIS_MIXED.Validation
git diff --checkpassed.The previous PR revision had unrelated Psalm failures concerning
PhpVersionNotSupportedExceptionand Dusk failures in notification badges and the item creation modal. Those areas are outside this change; CI will run again on this revision.