Skip to content

Guard tab auto-activation against a stale remembered tab id (#2922) #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wakqasahmed wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Guard tab auto-activation against a stale remembered tab id (#2922) #3149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion resources/js/controllers/tabs_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ export default class extends ApplicationController {
});

if (activeId !== null && !this.data.get("active-tab")) {
Tab.getOrCreateInstance(document.getElementById(activeId)).show();
const activeTabElement = document.getElementById(activeId);

// The id remembered in localStorage may belong to a tab that
// doesn't exist on this screen (e.g. a stale id from another
// page that shares the same pathname), so it has to be
// confirmed before handing it to Bootstrap's Tab component.
if (activeTabElement !== null) {
Tab.getOrCreateInstance(activeTabElement).show();
}
}
}

Expand Down
Loading