fix(l10n): correct zh-Hans Favorite and unify Mongolian note terminology#559
Open
DeepDiver1975 wants to merge 1 commit into
Open
fix(l10n): correct zh-Hans Favorite and unify Mongolian note terminology#559DeepDiver1975 wants to merge 1 commit into
DeepDiver1975 wants to merge 1 commit into
Conversation
Two pre-existing translation issues, independent of the 2.2.0 backfill:
- zh-Hans (Simplified Chinese): "Favorite" was "我的最愛" — Traditional
characters (愛/最愛) and a noun phrase ("My Favorites"). Use "收藏",
the Simplified verb form, matching zh_CN.
- mn (Mongolian): the note strings mixed two lexemes — "Тэмдэглэгээ"
(marking/annotation) for Notes/New note/Delete note vs "Тэмдэглэл"
(note/memo) elsewhere. Standardise on "Тэмдэглэл" ("Тэмдэглэлүүд" for
the plural "Notes" title), the accurate term for a note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
reviewed
Jul 26, 2026
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
This is a struggle, because I have no clue if these are really improvements to these translations. We need to find a real person who is fluent in writing these languages. How do we do that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pre-existing translation issues surfaced while reviewing the 2.2.0 l10n backfill (#555). Both exist on
mastertoday and are independent of that release.Changes
Favoritewas我的最愛, which is written in Traditional characters (愛/最愛; Simplified is 爱/最爱) and phrased as a noun ("My Favorites") rather than the verb/label sense. Changed to收藏, the standard Simplified verb form, matching whatzh_CNalready uses. (The Traditional localeszh_HK/zh_TWcorrectly keep我的最愛.)Тэмдэглэгээ("marking/annotation") for Notes / New note / Delete note, versusТэмдэглэл("note/memo") used for the newer strings. Standardised onТэмдэглэл(Тэмдэглэлүүдfor the plural Notes title), the accurate term for a note.Each language's
.jsand.jsonpair is kept in sync; JSON validated.Notes
🤖 Generated with Claude Code