Repository navigation
✅ rewrite MoveTest against public API - #94
Merged
Merged
Conversation
- Use move()/undo() instead of publicator build/make/undo. Engine decides flags. - Add real en passant undo round-trip (h2-h4, gxh3). Old test never set the ep square. - Fix SAN ep FEN to include the ep square. - Assert a8=Q+ on promotion: a8-h1 diagonal checks the king. - Drop unused publicator helpers. Only getBoardHash and perft remain.
There was a problem hiding this comment.
🟢 Approval recommended
The test refactor preserves coverage while validating realistic public-API behavior and removes only unused helpers.
0 open findings
What changed in this PR
Rewrites move tests around public APIs while improving en passant, promotion, SAN, and undo coverage.
Changes:
- Replaced protected-method proxies with
move(),undo(), andmoves(). - Added data-driven SAN and undo round-trip tests.
- Removed unused
ChessPublicatorhelpers.
| File | Description |
|---|---|
tests/MoveTest.php |
Exercises move behavior through public APIs. |
tests/ChessPublicator.php |
Removes obsolete protected-method wrappers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #91 (step 3).