Modernize contract drafting and unify every PDF template - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract PDFs now share one typographic system across all ten designs and seven document kinds: optically sized bundled fonts, a narrower reading column, hanging clause numbers, clear paragraph and list spacing, stable heading gaps and usable signature fields. Page layout protects short paragraphs and list introductions, keeps compound title words intact, and groups closing clauses with execution when they fit. Long party names and email addresses wrap cleanly.
Adds explicit UK, US, Singapore and cross-border legal profiles and technology/design/startup clause packs. Current wording covers IP, liability, confidentiality, notices, data handling and execution; headings use consistent sentence case and dense provisions are divided at topic boundaries. NCNDA and loan creation work against the shared legacy database. Older contracts retain their recorded clause-pack versions.
The rendering pipeline preserves wrapped content, reads cached fonts directly, excludes internal notes and replaces the destination only after successful compilation. Lifecycle controls lock edits after a recorded signature; law, terms and paths receive stricter validation. The Rust stack is updated with a committed dependency lockfile.
Validation: 32 Rust tests, strict Clippy and formatting, release build, dependency audit without reported advisories, agent CLI conformance and 77 PDF checks. The PDF matrix covers all 10 templates × 7 kinds, specialised packs, US Letter, long custom content, long legal names, text bounds, missing-term rejection and preservation after compiler failure. Visual review covered all ten designs and seven kinds, with corrected final previews checked again. CI runs lint, tests, conformance and PDF checks with pinned actions and finance-core revision.
Legal profiles supply limited law, venue and notice choices; the source-linked legal scope document records their limits. Signature commands remain administrative records. Examples are fictional; private databases, personal details and exports are excluded.