Conversation
📦 Bundle size impactComparing
Thresholds — 🟡 ≥10% or ≥5.0 KB · 🟠 ≥20% or ≥15.0 KB (bundled). Percentage only applies once the baseline is ≥ 10 KB. Informational — this check never blocks merge. |
TarikGul
reviewed
Oct 4, 2026
| * a watch that waits on that query stops emitting. | ||
| */ | ||
| function onRejection(matched: unknown, err: (error: unknown) => void): void { | ||
| Promise.resolve(matched).catch(err); |
Member
There was a problem hiding this comment.
One edge worth knowing about. match is _promise.then(res => res.match(ok, err)), so if the err arm itself throws (it bottoms out at onMessage, which is PAPI supplied and could throw) the match promise rejects and this catch runs the same err a second time, giving a duplicate error frame and a double settle on the operation sites. Very unlikely and not blocking, but it is new behavior from the wrapping, so maybe guard the catch to only fire when neither arm ran.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.match, which a rejection never reaches.TrUAPI request host:N (wire 3, 3) timed out after 120000msand the same for methods 4 and 5. Its chest can then stay on its loading screen when one of its reads is the request left unsettled.getHeadStorage,unpinHeadandgetHeadHeaderreject and checks that each request gets a -32603 answer. It fails on main with three unhandled rejections.papi-provider.tsnext to fix(host): back off synthetic transport-interrupt stops #427, which changes the follow stop path, so whichever lands second may need a small rebase.