[RHCLOUD-48734] Add traditional expandable row support to DataViewTable#681
Open
katarinazaprazna wants to merge 4 commits into
Open
Conversation
|
To be consistent with a simple expandable row pattern from PF,
More technical issues consult with Patternfly team. |
karelhala
reviewed
Jul 21, 2026
karelhala
left a comment
Collaborator
There was a problem hiding this comment.
Overall solid PR — clean separation of compound vs traditional expand, good test coverage, docs well-structured. Three inline comments.
Co-authored-by: Karel Hala <ch4rlien@gmail.com>
Co-authored-by: Karel Hala <ch4rlien@gmail.com>
Co-authored-by: Karel Hala <ch4rlien@gmail.com>
Author
|
Thanks for catching those edge cases! I've applied the changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
columnIdonExpandableContentchanged from required to optional, existing consumers withcolumnIdget identical compound behaviorTest plan
Closes RHCLOUD-48734
Assisted-by: Claude Code